[PATCH] D79164: [CostModel] getCFInstrCost

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov accepted this revision.
dfukalov added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: bmahjour.

LGTM, although minor change in test' comment



================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/aarch64-predication.ll:10-15
 ; "optsize" attribute to disable all interleaving calculations.  A cost of 4
 ; for %tmp4 indicates that we would scalarize it's operand (%tmp3), giving
 ; %tmp4 a lower scalarization overhead.
 ;
 ; COST-LABEL:  predicated_udiv_scalarized_operand
+; COST:        LV: Found an estimated cost of 5 for VF 2 For instruction: %tmp4 = udiv i64 %tmp2, %tmp3
----------------
samparker wrote:
> dfukalov wrote:
> > The comment for the test explicitly says we need cost of 4 here.
> I'm not really sure what causes this, but it at least shouldn't stop the vectorizer from performing the scalarization.
Well, so the comment should be patched too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79164/new/

https://reviews.llvm.org/D79164