[PATCH] D81436: [AArch64][GlobalISel] Add G_EXT and select ext using it

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 14:49:52 PDT 2020


paquette updated this revision to Diff 270518.
paquette added a comment.

Rename function and address nit.

Also update a couple testcases I apparently forgot to run.

For the zip test, disable the ext combine. The ext combine has a higher priority than the zip combine, and G_EXT was being produced for a couple of the negative zip tests. Since those tests are supposed that we will not produce a G_ZIP in those situations, running the ext combine (and thus not exercising the code) is undesirable.

For the splat test, it was messed up because it was already regbankselected, and the ext combine introduces G_CONSTANTs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81436/new/

https://reviews.llvm.org/D81436

Files:
  llvm/lib/Target/AArch64/AArch64Combine.td
  llvm/lib/Target/AArch64/AArch64InstrGISel.td
  llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-ext.mir
  llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-shuffle-splat.mir
  llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-zip.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-ext.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81436.270518.patch
Type: text/x-patch
Size: 36821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200612/b67ca7a5/attachment-0001.bin>


More information about the llvm-commits mailing list