[PATCH] D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 14:14:45 PDT 2020


sbc100 added a comment.

I'm worried that if one interprets the "easier to maintain" argument too broadly then we end up with the "“almost always auto” situation that the guidelines specifically want to avoid.

Some argue that its good to use `auto` everywhere that you store the return value of another function since then you can then change the return type of an function without having the change all the callsites.    I think that argument is one that llvm doesn't currently accept.

Am I misinterpreting the llvm guidelines?  Do you think that `auto var = SomeFunction()` should generally be preferred based on your reading of the guide?   Or maybe you only thinking about function that return types that have builtin lossy coercions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81704/new/

https://reviews.llvm.org/D81704





More information about the llvm-commits mailing list