[PATCH] D81689: [WebAssembly] New-style command support

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Interesting direction!   I'm only skimmed it for now.   Not strongly opposed to this direction although it makes me sad to see more codegen/magic in the linker.



================
Comment at: lld/wasm/Driver.cpp:476
+    }
+  }
 }
----------------
Can we make this a separate change?  Its seems pretty distinct.


================
Comment at: lld/wasm/MarkLive.cpp:76
-    }
-  }
 }
----------------
Is this just a de-duplication with the code below?  It is related to this change to independent?


================
Comment at: lld/wasm/Writer.cpp:1190
+        WasmSym::callCtors->getName() != config->entry &&
+        !config->exportedSymbols.count(WasmSym::callCtors->getName())) {
+      log("-- createCommandExportWrappers");
----------------
Can you replace these 2 lines with `WasmSym::callCtors->isExported()` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81689/new/

https://reviews.llvm.org/D81689