[PATCH] D75218: Make asm printer use custom separator instead of hard-coded tabs.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 09:45:38 PDT 2020


MaskRay added a comment.

@oontvoo Can you describe your motivation behind this change? This is a reasonable change if you want to change it to spaces but the motivation in the description will help.



================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp:719
   if (isTblTbxInstruction(MI->getOpcode(), Layout, IsTbx)) {
-    O << "\t" << (IsTbx ? "tbx" : "tbl") << Layout << '\t'
+    O << "\t" << (IsTbx ? "tbx" : "tbl") << Layout << Separator
       << getRegisterName(MI->getOperand(0).getReg(), AArch64::vreg) << ", ";
----------------
Why is the first tab not changed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75218/new/

https://reviews.llvm.org/D75218





More information about the llvm-commits mailing list