[PATCH] D80860: Exact integer emptiness checks for FlatAffineConstraints

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 03:45:20 PDT 2020


bondhugula added inline comments.


================
Comment at: mlir/lib/Analysis/Presburger/Simplex.cpp:73
+///
+/// If the tableau is not big enough to accomodate the extra row, we extend it.
+///
----------------
Nit: You could leave the first three lines as the doc comment and move the ones below inline into the method as regular comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80860/new/

https://reviews.llvm.org/D80860





More information about the llvm-commits mailing list