[PATCH] D81525: [Support] Ensure errs() is constructed after outs() and don't rerun tie when errs() is called

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 12 01:03:16 PDT 2020


sammccall added a comment.

@maskray sorry for turning this review thread into a mess - i was directed here but probably should rather have kept the discussions separate.

Thanks for disabling the by-default behavior for the moment. If we turn it back on then the lack of the "usual thread-safety guarantees" seems like a good thing to call out in the comments.

We did indeed turn this off in clangd explicitly, I'll leave that in in case we roll the default forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81525/new/

https://reviews.llvm.org/D81525





More information about the llvm-commits mailing list