[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 20:33:08 PDT 2020


Different versions of bfd linker may also exhibit different problems, so it
is a pain to try to find all workarounds.  Having an option for now is fine.

On Thu, Jun 11, 2020 at 8:20 PM Petr Hosek via Phabricator <
reviews at reviews.llvm.org> wrote:

> phosek added a comment.
>
> In D76802#2089052 <https://reviews.llvm.org/D76802#2089052>, @phosek
> wrote:
>
> > @davidxl Do you have any preference between the current solution which
> uses the artificial padding in `__llvm_prf_data` section to workaround the
> BFD ld bug, and a backend feature flag that could be set to enable this
> feature?
>
>
> The latter might be preferable because there's another bug in trunk BFD ld
> which causes to enter infinite loop, see D72904 <
> https://reviews.llvm.org/D72904> for more details.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D76802/new/
>
> https://reviews.llvm.org/D76802
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200611/bb5a62c7/attachment.html>


More information about the llvm-commits mailing list