[PATCH] D81109: llvm-link: Add support for archive files as inputs.

Jan Sjödin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 18:11:17 PDT 2020


jsjodin added inline comments.


================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:209
+}
+
 namespace {
----------------
jdoerfert wrote:
> High level: The code is pretty "unqualified `auto`" heavy. While I guess this is neither performance critical nor too important, I would recommend to either specify some types where it might be helpful and use qualifiers, `const`, `*`, `&` where applicable.
I had specified some types before submitting the patch, but changed them to auto, since it looked like it was the preferred way of doing things. I can specify some types to make the code easier to follow.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81109/new/

https://reviews.llvm.org/D81109





More information about the llvm-commits mailing list