[PATCH] D81562: [DebugInfo] Unify Cursor usage for all debug line opcodes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 14:20:29 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:764
   while (*OffsetPtr < EndOffset) {
+    DataExtractor::Cursor Cursor(*OffsetPtr);
+
----------------
What about hoisting Cursor and refactoring more `*OffsetPtr` to use Cursor?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81562/new/

https://reviews.llvm.org/D81562





More information about the llvm-commits mailing list