[PATCH] D81525: [Support] Ensure errs() is constructed after outs() and don't rerun tie when errs() is called

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 13:47:58 PDT 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/Support/raw_ostream.cpp:880
+  // Ensure outs() is constructed before the unbuffered stderr stream so that
+  // outs() will be destructed after outs() and the TiedStream field of Init.S
+  // will not become dangling. The tie call is called once, thus the user can
----------------
jhenderson wrote:
> destructed -> destroyed
> opt out -> opt out of
"be destructed" is common in C++. I will not change it.

Will change opt out to opt out of


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81525/new/

https://reviews.llvm.org/D81525





More information about the llvm-commits mailing list