[PATCH] D80915: [FileCheck] Implement * and / operators for ExpressionValue.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm marked 3 inline comments as done.
paulwalker-arm added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:540
+  // Test negative and positive value.
+  EXPECT_EQ(ExpressionValue(5) == ExpressionValue(-3), 0);
+  EXPECT_EQ(ExpressionValue(5) != ExpressionValue(-3), 1);
----------------
jhenderson wrote:
> Replace these with `EXPECT_TRUE`/`EXPECT_FALSE`.
This was fixed via https://reviews.llvm.org/D81094.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:543
+  EXPECT_EQ(ExpressionValue(-2) == ExpressionValue(6), 0);
+  EXPECT_EQ(ExpressionValue(-2) != ExpressionValue(6), 1);
+
----------------
jhenderson wrote:
> Also test two values that are identical except for positive/negative, e.g. 1 and -1.
This was fixed via https://reviews.llvm.org/D81094.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:549
+  EXPECT_EQ(ExpressionValue(-3) == ExpressionValue(-3), 1);
+  EXPECT_EQ(ExpressionValue(-3) != ExpressionValue(-3), 0);
+
----------------
jhenderson wrote:
> For completeness, you probably also want to compare values that are different, e.g. 3 and 7. Same for the positive case.
This was fixed via https://reviews.llvm.org/D81094.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80915/new/

https://reviews.llvm.org/D80915