[PATCH] D81544: [LVI] Make use of 'assume'-provided data

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 11:00:34 PDT 2020


fhahn added a comment.

In D81544#2087285 <https://reviews.llvm.org/D81544#2087285>, @junparser wrote:

> In D81544#2084732 <https://reviews.llvm.org/D81544#2084732>, @fhahn wrote:
>
> > In D81544#2084620 <https://reviews.llvm.org/D81544#2084620>, @junparser wrote:
> >
> > > since we still need discuss about the invoke of getValueInBlock, I'll split this patch into two parts.
> >
> >
> > I think this case could also be handled naturally by IPSCCP using PredicateInfo. Currently does only use range info from conditional branches, but I don't think there's any reason for not also using info from assume predicates, other than me not having time to implement it yet. If you want to give it a try, it would need to be added here: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Scalar/SCCP.cpp#L1243
>
>
> Thanks for the info. I'll check later.


Great, please feel free to reach out in case there are any questions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81544/new/

https://reviews.llvm.org/D81544





More information about the llvm-commits mailing list