[PATCH] D81373: [WIP] Basic bfloat support on Arm

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 11:00:32 PDT 2020


labrinea added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2090
+       (VA.getValVT() == MVT::f16 || VA.getValVT() == MVT::bf16)) {
+      assert((VA.getValVT() == MVT::f16) == Subtarget->hasFullFP16() &&
              "Lowering f16 type return without full fp16 support");
----------------
Actually, these assertions can go wrong if you are lowering one of the two value types with both the Architecture extensions enabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81373/new/

https://reviews.llvm.org/D81373





More information about the llvm-commits mailing list