[PATCH] D81628: [WebAssembly] Make BR_TABLE non-duplicable

Thu Jun 11 10:28:05 PDT 2020

tlively marked an inline comment as done.
tlively added a comment.

In D81628#2087315 <https://reviews.llvm.org/D81628#2087315>, @aheejin wrote:

> LGTM either with `isNotDuplicable` or `isConvergent`, as long as it works. I'm not familiar with what `isConvergent` is used for either, so..
>
> Just to confirm, this is separate from why final.c in https://bugs.chromium.org/p/v8/issues/detail?id=10606 is slow, right?

Right, if I'm reading that bug correctly, there is also a register allocation issue in V8 making switches in loops slow.

================
Comment at: llvm/test/CodeGen/WebAssembly/indirectbr.ll:30
 ; CHECK: end_loop
+; CHECK: end_function
 ; CHECK: test1.targets:
----------------
aheejin wrote:
> Were we duplicating `br_table` even for this simple example? Is that why the test result changed?
That's right 👍 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81628/new/

https://reviews.llvm.org/D81628