[PATCH] D81585: [AIX][XCOFF] Decode trace back table information for xcoff object file for llvm-objdump -d

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 09:20:07 PDT 2020


DiggerLin marked 2 inline comments as done.
DiggerLin added a comment.

In D81585#2086953 <https://reviews.llvm.org/D81585#2086953>, @jhenderson wrote:

> Please run clang-format on all your new code. You're adding an awful lot in one go, and I can't believe that it's all got test cases. I think you'd be better to split it down into smaller pieces, perhaps only implementing a small part of the dumper functionality in each.
>
> Is there an existing tool that the output format is supposed to match? I'm not particularly keen on the output as-is, so would like to suggest changes if you're not trying to match an existing style.


hi James,

1. there is tool named "dis" in the the IBM aix xlc compiler , the output format of the llvm-objdump for traceback table match that tools. and the explain of the bit field of the trace back table can be found in the 64-Bit ELF V2 ABI Specification: Power Architecture section 3.8.3
2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585





More information about the llvm-commits mailing list