[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/include/llvm/IR/PassManager.h:413
 
+/// LLVM-provided high-level optimization levels.
+///
----------------
I think this change - moving OptimizationLevel out - should be in its own patch, to avoid noise.


================
Comment at: llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:22
 #include "llvm/IR/ModuleSummaryIndex.h"
+#include "llvm/IR/PassManager.h"
 #include "llvm/LTO/LTO.h"
----------------
It's unfortunate we now need to pull pass management into places that didn't have that dependency. IIUC, the goal of this overall effort includes piping though the full user-requested optimization parameters (i.e. both speed and size). Given the likely diversity of the consumers, it may make sense to move OptimizationLevel in its own header?


================
Comment at: llvm/tools/opt/CMakeLists.txt:20
   ObjCARCOpts
+  Passes
   Remarks
----------------
Nit: make this change separately, and since it's just a style change, it can probably be just submitted with no review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81223/new/

https://reviews.llvm.org/D81223