[PATCH] D81580: [ADT] Add Bitfield utilities

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added a comment.

In D81580#2086998 <https://reviews.llvm.org/D81580#2086998>, @courbet wrote:

> Can you create an example patch rebased on this to show how this changes the bit twiddling code for an example instruction ?


Here it is D80276 <https://reviews.llvm.org/D80276>
I've added comments to highlight dubious logic.

> Maybe this could go through an RFC ?

You're right. I'll send an email, thank you.

> The only thing that this would not handle is if an instruction does its bit twidling based on some dynamic property, e.g. `SubclassData & 1 << (dynamic_value) `. But your proposal does not have to be used for that case.

Yes indeed, this code is for compile time bit fields.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81580/new/

https://reviews.llvm.org/D81580