[PATCH] D81665: [lit] Fix handling of various keyword parse errors

[Joel E. Denny via Phabricator via llvm-commits]

jdenny created this revision.
jdenny added reviewers: ldionne, yln, delcypher.
Herald added a subscriber: dexonsmith.
Herald added a project: LLVM.

In TestRunner.py, D78589 <https://reviews.llvm.org/D78589> extracts a `_parseKeywords` function from
`parseIntegratedTestScript`, which then expects `_parseKeywords` to
always return a list of keyword/value pairs.  However, the extracted
code sometimes returns an unresolved `lit.Test.Result` on a keyword
parsing error, which then produces a stack dump instead of the 
expected diagnostic.

This patch fixes that, makes the style of those diagnostics more
consistent, and extends the lit test suite to cover them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81665

Files:
  llvm/utils/lit/lit/TestRunner.py
  llvm/utils/lit/tests/Inputs/shtest-keyword-parse-errors/empty.txt
  llvm/utils/lit/tests/Inputs/shtest-keyword-parse-errors/lit.cfg
  llvm/utils/lit/tests/Inputs/shtest-keyword-parse-errors/multiple-allow-retries.txt
  llvm/utils/lit/tests/Inputs/shtest-keyword-parse-errors/unterminated-run.txt
  llvm/utils/lit/tests/shtest-keyword-parse-errors.py
  llvm/utils/lit/tests/unit/TestRunner.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81665.270150.patch
Type: text/x-patch
Size: 7287 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200611/e14f5a4b/attachment.bin>