[PATCH] D77557: [DWARFDebugLine] Use truncating data extractors for prologue parsing

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 04:14:01 PDT 2020


labath marked 2 inline comments as done.
labath added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:436
+        ": parsing ended (at offset 0x%8.8" PRIx64
+        ") before reaching the prologue at offset 0x%8.8" PRIx64,
+        PrologueOffset, *OffsetPtr, EndPrologueOffset));
----------------
jhenderson wrote:
> Oops, just spotted a mistake here: "reaching the prologue at" -> "reaching the prologue end at"
> 
> Are you okay to fix?
Done in 0b781db9087. Thanks for catching that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77557/new/

https://reviews.llvm.org/D77557





More information about the llvm-commits mailing list