[PATCH] D81607: BreakCriticalEdges for callbr indirect dests

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/CallSiteSplitting/callsite-split-callbr.ll:39
+  call void @callee(i1 %phi)
+  callbr void asm sideeffect "", "r,X,~{dirflag},~{fpsr},~{flags}"(i1 %phi, i8* blockaddress(@caller, %End2))
+  to label %End [label %End2]
----------------
Does `callbr` always take the destinations as `blockaddress` or could an arbitrary `i8*` value be used? Then doing the splitting here would only be safe if we can update the `blockaddress` constant and not in other cases I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81607/new/

https://reviews.llvm.org/D81607