[PATCH] D81238: Correctly report modified status for HWAddressSanitizer

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 03:37:17 PDT 2020


vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1162
   DenseMap<AllocaInst *, AllocaInst *> AllocaToPaddedAllocaMap;
   for (AllocaInst *AI : AllocasToInstrument) {
     uint64_t Size = getAllocaSizeInBytes(*AI);
----------------
there are changes below. if we assume Changed is true by this point, then probably we should return true below?
maybe remove Changed and always return true after line 1140


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81238/new/

https://reviews.llvm.org/D81238





More information about the llvm-commits mailing list