[PATCH] D81575: [llvm-objcopy] Fix RPathLC.cmdsize

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 01:50:42 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nit.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test:25
+
+## Check if cmdsize accounts for NULL terminator.
+# RUN: yaml2obj %p/Inputs/x86_64.yaml -o %t.x86_64
----------------
if -> that

(more clearly indicates that it is intended that it does account for the terminator)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81575/new/

https://reviews.llvm.org/D81575





More information about the llvm-commits mailing list