[PATCH] D81507: [llvm][NFC] Factor some common data in InlineAdvice

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 16:41:44 PDT 2020


mtrofin marked 2 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/include/llvm/Analysis/InlineAdvisor.h:51
 public:
+  InlineAdvice(InlineAdvisor *Advisor, CallBase &CB,
+               OptimizationRemarkEmitter &ORE, bool IsInliningRecommended);
----------------
davidxl wrote:
> why making it public?
see D81515 - it is a good-enough Advice if we don't want to track any state between advice and inline, and there are a few cases like that in the MLInlineAdvisor (e.g. if the call site or callee are 'inline never')


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81507/new/

https://reviews.llvm.org/D81507





More information about the llvm-commits mailing list