[PATCH] D76836: [AMDGPU] Add G16 support to image instructions

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 15:35:40 PDT 2020


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5713
+
+    // Gradients are packed with undef for each coordinate
+    // 1D: undef,dx/dh; undef,dx/dv
----------------
Maybe state that the comment uses "hi,lo" notation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76836/new/

https://reviews.llvm.org/D76836





More information about the llvm-commits mailing list