[PATCH] D81016: Adding InlineCostAnnotationPrinterPass for Inline Cost Analysis

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 14:28:51 PDT 2020


mtrofin added a comment.

In D81016#2086070 <https://reviews.llvm.org/D81016#2086070>, @knaumov wrote:

> Ping


Oh - sorry, I saw you made changes for the comments on lines 420, 424 and 742, but didn't see anything on 59 and 2525, so I assumed you were looking to address those. Also, would it make sense to split off the pass in its own change (the other comment).

Could you also mark 'done' the addressed comments (it's easier to keep track for anyone looking at the CL)

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81016/new/

https://reviews.llvm.org/D81016





More information about the llvm-commits mailing list