[PATCH] D81584: [BreakCritEdges] Support preserving loop-simplify form with indirectbr. (WIP)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 11:41:37 PDT 2020


efriedma added a comment.

We could make preserving LoopSimplify form optional, and let users turn it on with CriticalEdgeSplittingOptions.  That way, if some user isn't prepared to handle the transform, they can just let LoopSimplify form break, and fix it up later if necessary.  We probably should do that anyway: there isn't any obvious connection between preserving LoopInfo and preserving LoopSimplify form.



================
Comment at: llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp:324
+          DT->applyUpdates({{DominatorTree::Insert, NewBB, ExitCont},
+                            {DominatorTree::Delete, NewBB, DestBB}});
         }
----------------
Missing LoopInfo update?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81584/new/

https://reviews.llvm.org/D81584





More information about the llvm-commits mailing list