[PATCH] D81517: Extend or truncate __ptr32/__ptr64 pointers when dereferenced.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 11:05:15 PDT 2020


arsenm added a comment.

In D81517#2085442 <https://reviews.llvm.org/D81517#2085442>, @craig.topper wrote:

> I'm worried that load/store aren't the only things that can use these pointers. Or that we will have transformed the load/store into a target specific load/store before type legalizaton kicks in. I'm not an expert on address spaces, but it feels to me like we should have an address space cast in IR before the pointers are used by load/store. And that the address space cast is what should be turned into trunc or extend. @arsenm what do you think?


I don't think the addressing mode matching should be responsible for inserting this (it's also suspicious that this would need to look at the memory address space)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81517/new/

https://reviews.llvm.org/D81517





More information about the llvm-commits mailing list