[PATCH] D81575: [llvm-objcopy] Fix RPathLC.cmdsize

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 10:32:28 PDT 2020


smeenai added a comment.

The change looks good, but it'd be helpful for the commit message to just contain the details about the issue directly instead of pointing to another review. (The `+ 1` is to account for the NUL terminator, as far as I can tell.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81575/new/

https://reviews.llvm.org/D81575





More information about the llvm-commits mailing list