[PATCH] D81402: [AArch64] Extend AArch64SLSHardeningPass to harden BLR instructions.

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls marked 6 inline comments as done.
kristof.beyls added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SLSHardening.cpp:208
+      MF.getSubtarget<AArch64Subtarget>().getInstrInfo();
+  // Grab the entry MBB and erase any other blocks. O0 codegen appears to
+  // generate two bbs for the entry block.
----------------
ostannard wrote:
> Is this something which could be fixed in ThunkInserter?
Maybe, but I think that should be done as a separate patch as it's probably target-independent.


================
Comment at: llvm/lib/Target/AArch64/AArch64SLSHardening.cpp:232
+                                    MachineBasicBlock::iterator MBBI) const {
+  // Split the current basic block as follows:
+  // Before:
----------------
ostannard wrote:
> This comment is a bit misleading, we're not actually splitting the basic block (that's terminology used elsewhere in LLVM for replacing one basic block with two).
Hopefully the new comment is better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81402/new/

https://reviews.llvm.org/D81402