[PATCH] D81558: [NewPM] Introduce PreserveCFG check

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 07:37:38 PDT 2020


fedor.sergeev added a comment.

I'm not sure if introducing base for standard instrumentation classes (Instrument/Instruments) is a good change or not.
What problem does it solve?
Anyway that part seems to be rather orthogonal to the checker itself.
I would like to have it separated - either introduce Instrument/Instruments thing before the checker and then use it,
//OR// implement the checker the same way as other standard instrumentations are done (just as separate members) and only then refactor it all into Instrument/Instruments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81558/new/

https://reviews.llvm.org/D81558





More information about the llvm-commits mailing list