[PATCH] D81542: [ObjectYAML][test] Add test cases for the DWARF64 .debug_addr section.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml:384
+##                         |                          +--- version (2-byte)
+##                         +------------------------- a1) unit_length (DWARF64, 12-byte)
+##
----------------
Higuoxing wrote:
> grimar wrote:
> > At first I wanted to write that 0xffffffff is not a length, but a special mark, but
> > DWARF spec says "an initial length field is 12 bytes in size", so this seems fine.
> > Perhaps I'd mention that 0xffffffff is a special part though.
> I have discussed it with @jhenderson in [D81063](https://reviews.llvm.org/D81063#inline-744985). Does it make sense here?
I think it is not harmfull to mention it briefly:

```
a1) unit_length (DWARF64, 12-byte, starts from 0xffffffff)
```

I have no strong opinion on this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81542/new/

https://reviews.llvm.org/D81542