[PATCH] D80888: AMDGPU/GlobalISel: Make G_IMPLICIT_DEF legality more consistent

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 03:14:19 PDT 2020


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

I'm not really an expert but it looks good to me.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:465
+      // s1 and s16 are special cases because they have legal operations on
+      // them, don't don't really occupy registers in the normal way.
+      .legalFor({S1, S16})
----------------
Typo "don't don't".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80888/new/

https://reviews.llvm.org/D80888





More information about the llvm-commits mailing list