[PATCH] D81515: [llvm] Release-mode ML InlineAdvisor

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Including the models in the LLVM tree is problematic.

I'm not sure there's a formal policy on this, but generally part of being an open-source project is that the source is available in human-readable format.  With the exception of a few regression tests for binary parsers, the entire LLVM  tree is human-readable.  A model clearly doesn't count as human-readable.

If it isn't practical to train the model as part of the LLVM build (because it would take too long), it might make sense to commit binary files.  There's some precedent for this in-tree: lowering for shuffles on some targets is based on a precomputed table, built using a utility that isn't run as part of the normal build process. But I would expect reproducible instructions for how to generate the files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81515/new/

https://reviews.llvm.org/D81515