[PATCH] D81447: [llvm] Added support for stand-alone cmake object libraries.

Tue Jun 9 18:48:22 PDT 2020

phosek added inline comments.

================
Comment at: llvm/cmake/modules/AddLLVM.cmake:390
+#     If STATIC or SHARED are
+#     also specified, create an OBJECT library target named obj.${name} in
+#     addition to those.
----------------
I don't understand this part of the comment, does it mean that we always want to create `OBJECT` library even either `STATIC` or `SHARED` is specified?

================
Comment at: llvm/cmake/modules/AddLLVM.cmake:698
+# not referenced.
+macro (add_implementation_detail name)
+  cmake_parse_arguments(ARG "PUBLIC;PRIVATE" "" "" ${ARGN})
----------------
I'm not a big fan of the name `add_implementation_detail` as it doesn't really match the rest of functions. How about `add_llvm_internal_library` or something along those lines?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81447/new/

https://reviews.llvm.org/D81447