[PATCH] D80377: [flang] Google test infrastructure support for unittests

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 14:21:35 PDT 2020


tskeith added inline comments.


================
Comment at: flang/CMakeLists.txt:155
+    else()
+      message(FATAL_ERROR "gtest.h is missing from ${UNITTEST_DIR}/googletest/include/gtest" )
+    endif()
----------------
I get this. Is it what you're expecting?
```
CMake Error at CMakeLists.txt:164 (message):
  gtest.h is missing from /utils/unittest/googletest/include/gtest
```


================
Comment at: flang/README.md:168
+
+Unit tests:
+
----------------
Somewhere in here you should explain that you can't run unit tests in an out-of-tree build against an LLVM install.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377





More information about the llvm-commits mailing list