[PATCH] D81495: [SVE] Remove invalid calls to VectorType::getNumElements from BasicTTIImpl

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 13:48:38 PDT 2020


ctetreau added a comment.

> I'm not sure the `FIXME_ScalableVectorNotSupported` thing is useful here, as opposed to just writing `cast<FixedVectorType>()`.

I like it for the reasons I mentioned. Strictly speaking, it is equivalent to just doing the cast, but I think it provides documentation value. If people feel strongly about removing it, I can do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81495/new/

https://reviews.llvm.org/D81495





More information about the llvm-commits mailing list