[PATCH] D80591: Patch up pthread issues with GN build

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 13:15:05 PDT 2020


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e9142cbb909: Patch up issues with GN builds (pthread / libz) (authored by hctim).

Changed prior to commit:
  https://reviews.llvm.org/D80591?vs=269270&id=269647#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80591/new/

https://reviews.llvm.org/D80591

Files:
  llvm/utils/gn/build/libs/pthread/BUILD.gn


Index: llvm/utils/gn/build/libs/pthread/BUILD.gn
===================================================================
--- llvm/utils/gn/build/libs/pthread/BUILD.gn
+++ llvm/utils/gn/build/libs/pthread/BUILD.gn
@@ -5,9 +5,15 @@
   libs = [ "pthread" ]
 }
 
+config("pthread_link_time_config") {
+  visibility = [ ":pthread" ]
+  ldflags = [ "-pthread" ]
+}
+
 group("pthread") {
   # On Android, bionic has built-in support for pthreads.
   if (llvm_enable_threads && current_os != "win" && current_os != "android") {
     public_configs = [ ":pthread_config" ]
+    all_dependent_configs = [ ":pthread_link_time_config" ]
   }
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80591.269647.patch
Type: text/x-patch
Size: 629 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200609/8d484568/attachment.bin>


More information about the llvm-commits mailing list