[PATCH] D80235: [SVE] Eliminate calls to VectorType::getNumElements from BasicTTIImpl.h

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 13:14:27 PDT 2020


ctetreau abandoned this revision.
ctetreau added a comment.

After spending time trying to debug this test failure, I had some time to reflect on my approach. I have decided that changing the interface to explicitly work on FixedVectorType would be a mistake. Many or all of these operations should be possible for scalable vectors. The fact that they don't work is an issue to be fixed, and not a feature. With that in mind, I will abandon this patch in favor of D81495 <https://reviews.llvm.org/D81495> which just does the cast internally and does not change the interface.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80235/new/

https://reviews.llvm.org/D80235





More information about the llvm-commits mailing list