[PATCH] D81422: Change filecheck default to dump input on failure

Tue Jun 9 10:25:29 PDT 2020

mehdi_amini added inline comments.

================
Comment at: llvm/test/FileCheck/lit.local.cfg:42
 #   ; RUN: %ProtectFileCheckOutput FILECHECK_OPTS=-v \
 #   ; RUN: FileCheck -input-file %s %s 2>&1 \
 #   ; RUN: | FileCheck -check-prefix TRACE %s
----------------
jdenny wrote:
> Please add `-dump-input=never` to this first FileCheck call.  Otherwise, the example is broken because FileCheck never prints `expected string found in input` when `-dump-input=fail` regardless of `-v`.
Well spotted!

================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:117
-             "FILECHECK_DUMP_INPUT_ON_FAILURE environment variable.\n"
-             "This option is deprecated in favor of -dump-input=fail.\n"));

----------------
jdenny wrote:
> jdenny wrote:
> > Please mention in the patch summary that `-dump-input-on-failure` and `FILECHECK_DUMP_INPUT_ON_FAILURE` are being dropped.
> This is marked as done, but I don't see the change.
That's because I amended my commit locally but `arc` does not propagate the update to Phabricator apparently: https://phabricator.kde.org/T7711 ; I'll do it manually

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422