[PATCH] D80437: [CodeGen] Let computeKnownBits do something sensible for scalable vectors

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 10:25:37 PDT 2020


efriedma added a comment.

The code looks right.

For both this and the SimplifyDemandedBits/VectorElts patches, I'm not sure what we want to do about testing.  Currently, I assume some optimizations "work", and this breaks them.  And probably we do some incorrect optimizations.  It would be nice if we could have at least a little test coverage showing these changes have some effect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80437/new/

https://reviews.llvm.org/D80437





More information about the llvm-commits mailing list