[PATCH] D81450: [ObjectYAML][ELF] Add support for emitting the .debug_line section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 06:33:19 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:336
+  Machine: EM_X86_64
+DWARF:
----------------
Higuoxing wrote:
> grimar wrote:
> > I am not sure how much it is useful to check it, but anyways it looks probably it could be a generic test?
> > I.e. it could check that no .debug_* sections are emitted when there is an empty "DWARF" entry.
> > 
> > Perhaps it should be in a different test case file then.
> Thanks, Can we do it in a follow-up patch? There are several testcases like this.
Sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81450/new/

https://reviews.llvm.org/D81450





More information about the llvm-commits mailing list