[PATCH] D81450: [ObjectYAML][ELF] Add support for emitting the .debug_line section.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:173
+# RUN: yaml2obj --docnum=3 %s -o %t3.o
+# RUN: llvm-readobj --hex-dump=.debug_line %t3.o | FileCheck %s --check-prefix=SIZE
+
----------------
Is it a reason not to do the same as done like in `b)` ?

I.e
```
FileCheck %s -DSIZE=10 -DADDRALIGN=0 --check-prefixes=SHDR,SIZE
```


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:336
+  Machine: EM_X86_64
+DWARF:
----------------
I am not sure how much it is useful to check it, but anyways it looks probably it could be a generic test?
I.e. it could check that no .debug_* sections are emitted when there is an empty "DWARF" entry.

Perhaps it should be in a different test case file then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81450/new/

https://reviews.llvm.org/D81450