[PATCH] D81258: [yaml2obj] - Introduce a 10 Mb limit of the output by default and a --max-size option.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 04:54:04 PDT 2020


grimar updated this revision to Diff 269490.
grimar marked 12 inline comments as done.
grimar added a comment.

- Addressed review comments.

> Another idea I had to prevent accidental forgetting to check the limit at the end of the
>  function is to actually store an Error inside the ContiguousBlobAccumulator,
>  similar to the Cursor sub-class in the DataExtractor class.

It's probably a good idea. Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81258/new/

https://reviews.llvm.org/D81258

Files:
  llvm/include/llvm/ObjectYAML/yaml2obj.h
  llvm/lib/ObjectYAML/ELFEmitter.cpp
  llvm/lib/ObjectYAML/yaml2obj.cpp
  llvm/test/tools/yaml2obj/ELF/output-limit.yaml
  llvm/tools/yaml2obj/yaml2obj.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81258.269490.patch
Type: text/x-patch
Size: 34265 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200609/7989b87a/attachment-0001.bin>


More information about the llvm-commits mailing list