[PATCH] D81391: [RISC-V] Do not crash when using -ftrapping-math

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

Disclaimer: I haven't swotted up on these constrained intrinsics to review the proposed lowering yet, but added a quick note on the setOperationAction calls. I agree with Luis the test cases would probably be easier to read if using the hard float ABI. I think you're lacking any test coverage for f32 as well.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:214
   setOperationAction(ISD::INTRINSIC_WO_CHAIN, MVT::Other, Custom);
+  setOperationAction(ISD::STRICT_SINT_TO_FP, MVT::i64, Legal);
+  setOperationAction(ISD::STRICT_UINT_TO_FP, MVT::i64, Legal);
----------------
Should the instances of MVT::i64 be XLenVT?

I also would have imagined it would make sense for these setOperationAction calls to be guarded on hasStdExtF/hasStdExtD appropriately. Is that not the case here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81391/new/

https://reviews.llvm.org/D81391