[PATCH] D81310: Stabilize alloca slices sort in SROA

Mon Jun 8 08:48:28 PDT 2020

rampitec added a comment.

In D81310#2079887 <https://reviews.llvm.org/D81310#2079887>, @rampitec wrote:

> In D81310#2078610 <https://reviews.llvm.org/D81310#2078610>, @efriedma wrote:
>
> > I haven't looked at the code changes deeply, but would it be simpler to use std::stable_sort?
>
>
> std::stable_sort is C++17, we are still at C++14. It should be sufficient to use stable_sort here, but it will also require to remove -sroa-random-shuffle-slices option.

I stand corrected, in C++17 it only added some versions. Yes, I can change it to stable_sort, I seems to be sufficient.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81310/new/

https://reviews.llvm.org/D81310