[llvm] 30dfbf0 - [CodeGen,AArch64] Fix up warnings in splitStores

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 23:40:33 PDT 2020


Author: David Sherwood
Date: 2020-06-09T07:39:38+01:00
New Revision: 30dfbf03a206ad4f2a18d7fb904831ee728b6cbc

URL: https://github.com/llvm/llvm-project/commit/30dfbf03a206ad4f2a18d7fb904831ee728b6cbc
DIFF: https://github.com/llvm/llvm-project/commit/30dfbf03a206ad4f2a18d7fb904831ee728b6cbc.diff

LOG: [CodeGen,AArch64] Fix up warnings in splitStores

The code for trying to split up stores is designed for NEON vectors,
where we support arbitrary alignments. It's an optimisation designed
to improve performance by using smaller, aligned stores. However,
we currently only support 16 byte alignments for SVE vectors anyway
so we may as well bail out early.

This change fixes up remaining warnings in a couple of tests:

  CodeGen/AArch64/sve-callbyref-notailcall.ll
  CodeGen/AArch64/sve-calling-convention-byref.ll

Differential Revision: https://reviews.llvm.org/D80720

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
index e7f1c59eea4e..43a85d510d6a 100644
--- a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -12138,7 +12138,8 @@ static SDValue splitStores(SDNode *N, TargetLowering::DAGCombinerInfo &DCI,
 
   SDValue StVal = S->getValue();
   EVT VT = StVal.getValueType();
-  if (!VT.isVector())
+
+  if (!VT.isFixedLengthVector())
     return SDValue();
 
   // If we get a splat of zeros, convert this vector store to a store of


        


More information about the llvm-commits mailing list