[PATCH] D68230: [UpdateCCTestChecks] Allow asm in output with --allow-asm

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 8 23:25:40 PDT 2020


lebedev.ri added a comment.

In D68230#2081308 <https://reviews.llvm.org/D68230#2081308>, @greened wrote:

> Ok, so if test-suite seems.like a good place for such tests, can this change proceed?


Like this was already disscussed (i think?) in some -dev thread, how would that work?
If such tests are in test-suite, why would they need `update_cc_test_checks.py`?
If they need `update_cc_test_checks.py`, then now everyone also needs to run those tests before commit?
And what happens if they break? Just silently regenerate them?
Also, test-suite is not in monorepo, so you can't update those tests at the same time as making llvm change.

TLDR: i don't think the burden of proof has been provided here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68230/new/

https://reviews.llvm.org/D68230





More information about the llvm-commits mailing list