[PATCH] D81446: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:402
     break;
+  case ELF::R_AARCH64_PLT32:
   case ELF::R_AARCH64_PREL32: {
----------------
Reusing PREL32 seems wrong.


================
Comment at: llvm/test/MC/AArch64/elf-reloc-plt32.s:1
+// RUN: llvm-mc -triple=aarch64-none-fuchsia -filetype=obj %s -o - | \
+// RUN:   llvm-readobj -r | FileCheck %s
----------------
Just use `-triple=aarch64`. You are testing a generic ELF behavior. Don't append Linux or Fuchsia.


================
Comment at: llvm/test/MC/AArch64/elf-reloc-plt32.s:8
+
+// CHECK:      Relocations
+// CHECK:        Section (4) .rela.data
----------------
This line is redundant


================
Comment at: llvm/test/MC/AArch64/elf-reloc-plt32.s:9
+// CHECK:      Relocations
+// CHECK:        Section (4) .rela.data
+// CHECK-NEXT:     0x0 R_AARCH64_PLT32 extern_func 0x4
----------------
Replace 4 with `{{.*}}`


================
Comment at: llvm/test/MC/AArch64/elf-reloc-plt32.s:10
+// CHECK:        Section (4) .rela.data
+// CHECK-NEXT:     0x0 R_AARCH64_PLT32 extern_func 0x4
----------------
Better adding a `CHECK-NEXT: }`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81446/new/

https://reviews.llvm.org/D81446