[PATCH] D78861: [Attributor] [WIP] Track AA dependency using dependency graph

[Kuter Dinel via Phabricator via llvm-commits]

kuter added a comment.

In D78861#2081311 <https://reviews.llvm.org/D78861#2081311>, @kuter wrote:

> This does not compile for me. The compiler error that I get is about creating a `GraphTraits` specialization outside of the `llvm` namespace.
>  When i put the `GraphTraits` specializations in llvm namespace it does compile.
>
> But when I run it I get a segfault.




In D78861#2081341 <https://reviews.llvm.org/D78861#2081341>, @bbn wrote:

> In D78861#2081311 <https://reviews.llvm.org/D78861#2081311>, @kuter wrote:
>
> > This does not compile for me. The compiler error that I get is about creating a `GraphTraits` specialization outside of the `llvm` namespace.
> >  When i put the `GraphTraits` in llvm namespace it does compile.
>
>
> What do you mean by "put the `GraphTraits` in llvm namespace"?
>
> > But when I run it I get a segfault.
>
> Yes, I also got this segfault when running this on assign.ll. I think this issue is related to the `AbstractAttribute::print()` function and is not caused by the
>  dependency graph. I am currently looking into this and I will write a new print function for AA.


Hi I found out why. Your are dumping attributes after IR cleanup. IR Cleanup deletes the IR values that are no longer needed.  
But they are still referenced by the Attributes.

if you look at D81022 <https://reviews.llvm.org/D81022>, which will be merged soon.
The dump should happen after `::runTillFixpoint()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78861/new/

https://reviews.llvm.org/D78861